Better search and ticket numbers #7
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, betterSearch was always applied, now it follows the link behavior settings, only being applied when the mode is "tabs"
Contributor
Author
|
Just edited the application of the betterSearch function so that the behavior of the search bar follows the link behavior setting, as someone with their link behavior set to "window" likely would prefer the old functionality of opening in the window. Now betterSearch() is only called when the link behavior is set to "tabs" |
Contributor
Author
|
Closing, as searches are now opened in new tdx tabs, and the ticket numbers add little functionality. |
Sign in
to join this conversation on GitHub.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These additions modify the search functionality to have ticket numbers entered into the search bar open the corresponding ticket in a new tab, rather than in a new window as is done currently.
In addition, it adds a function that appends the current ticket number to the beginning of the webpage title.